Skip to content

unify progress dialogs (#23547) #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2025
Merged

unify progress dialogs (#23547) #171

merged 4 commits into from
Sep 19, 2025

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Sep 12, 2025 •
edited
Loading

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (71098f6) to head (071c344).
⚠️ Report is 211 commits behind head on main.

Files with missing lines Patch % Lines
...at/devtools/gateway/DevSpacesConnectionProvider.kt 0.00% 65 Missing ⚠️
.../gateway/view/steps/DevSpacesWorkspacesStepView.kt 0.00% 50 Missing ⚠️
.../redhat/devtools/gateway/openshift/DevWorkspace.kt 0.00% 11 Missing ⚠️
...com/redhat/devtools/gateway/DevSpacesConnection.kt 0.00% 10 Missing ⚠️
...com/redhat/devtools/gateway/util/ExceptionUtils.kt 0.00% 8 Missing ⚠️
...edhat/devtools/gateway/view/DevSpacesWizardView.kt 0.00% 4 Missing ⚠️
.../redhat/devtools/gateway/server/RemoteIDEServer.kt 0.00% 3 Missing ⚠️
...ools/gateway/view/steps/DevSpacesServerStepView.kt 0.00% 2 Missing ⚠️
...redhat/devtools/gateway/openshift/DevWorkspaces.kt 0.00% 1 Missing ⚠️
...lin/com/redhat/devtools/gateway/view/ui/Dialogs.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##            main    #171    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          4      28    +24     
  Lines         26     939   +913     
  Branches       0     145   +145     
======================================
- Misses        26     939   +913

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adietish adietish force-pushed the issue-23547 branch 3 times, most recently from d7f01b7 to 55e44a2 Compare September 15, 2025 09:33
@adietish adietish self-assigned this Sep 16, 2025
@adietish adietish marked this pull request as ready for review September 16, 2025 16:24
@adietish adietish marked this pull request as draft September 16, 2025 16:25
@adietish adietish mentioned this pull request Sep 16, 2025
Merged
@adietish adietish marked this pull request as ready for review September 16, 2025 17:54
This was referenced Sep 16, 2025
Open
Merged
This was referenced Sep 17, 2025
Merged
Open
Merged
@adietish
Copy link
Collaborator Author

@msivasubramaniaan, @vrubezhny, @azatsarynnyy: please review

azatsarynnyy
azatsarynnyy approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@adietish adietish merged commit 1cd2ceb into redhat-developer:main Sep 19, 2025
5 checks passed
@adietish adietish deleted the issue-23547 branch September 19, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@vrubezhny vrubezhny Awaiting requested review from vrubezhny

@msivasubramaniaan msivasubramaniaan Awaiting requested review from msivasubramaniaan

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway: progress bar dialogs should be consistent across the plugin
3 participants
@adietish @codecov-commenter @azatsarynnyy